Correct an issue with epoch timestamps in Conduit
ClosedPublic
Actions

Authored by epriestley on Jul 26 2016, 2:07 PM.

Details

Reviewers

chad

Maniphest Tasks

T11375: Date parameters ignored in Conduit maniphest.search method

Commits

rP637b58c7c83a: Correct an issue with epoch timestamps in Conduit

Summary

Fixes T11375. Some validation code was mishandling raw epoch timestamps.

For numeric values larger than 29999999 (e.g., 2999-12-25, christmas 2999), assume the value is a timestamp.

Test Plan

Used maniphest.search to query for modifiedStart, got a better result set and saw the dateModified constraint in the query.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 39254.Jul 26 2016, 2:07 PM

epriestley retitled this revision from to Correct an issue with epoch timestamps in Conduit.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11375: Date parameters ignored in Conduit maniphest.search method.

chad accepted this revision.Jul 26 2016, 3:45 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jul 26 2016, 3:45 PM

Closed by commit rP637b58c7c83a: Correct an issue with epoch timestamps in Conduit (authored by epriestley, committed by epriestley). · Explain WhyJul 26 2016, 6:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

field/

PhabricatorSearchDateField.php

8 lines

Diff 39255

View Options

src/applications/search/field/PhabricatorSearchDateField.php

Correct an issue with epoch timestamps in ConduitClosedPublicActions