Page MenuHomePhabricator
Differential D16306

Make Calendar month view events render a little more consistently
ClosedPublic
Actions

Authored by epriestley on Jul 15 2016, 7:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 26, 1:16 PM
Unknown Object (File)
Tue, Feb 18, 11:38 AM
Unknown Object (File)
Mon, Feb 17, 8:06 PM
Unknown Object (File)
Sun, Feb 16, 7:08 AM
Unknown Object (File)
Sat, Feb 15, 1:29 AM
Unknown Object (File)
Fri, Feb 14, 7:01 PM
Unknown Object (File)
Sun, Feb 9, 2:02 AM
Unknown Object (File)
Sun, Feb 9, 2:02 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11326: Improve Calendar v1 Design/UI/UX
Commits
rPb6c3d184d200: Make Calendar month view events render a little more consistently
Summary

Ref T11326. This just inches things forward a little bit:

  • Make it easier to see current day.
  • Line-through cancelled events.
  • Don't colorize the whole event title, just use an Attending/Invited/Custom icon.
  • Slightly subtler treatment for all-day events.
Test Plan

See screenshot in T11326.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 39215.Jul 15 2016, 7:10 PM
epriestley retitled this revision from to Make Calendar month view events render a little more consistently.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11326: Improve Calendar v1 Design/UI/UX.
Herald edited edge metadata. · View Herald TranscriptJul 15 2016, 7:10 PM
chad accepted this revision.Jul 15 2016, 7:36 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 15 2016, 7:36 PM
Closed by commit rPb6c3d184d200: Make Calendar month view events render a little more consistently (authored by epriestley, committed by epriestley). · Explain WhyJul 15 2016, 8:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
8 lines
src/
applications/
calendar/
query/
78 lines
storage/
60 lines
view/
20 lines
view/
phui/
calendar/
24 lines
28 lines
webroot/
rsrc/
css/
phui/
calendar/
17 lines
10 lines

Diff 39217

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...
View Options

src/applications/calendar/view/AphrontCalendarEventView.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarListView.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarMonthView.php

Loading...
View Options

webroot/rsrc/css/phui/calendar/phui-calendar-month.css

Loading...
View Options

webroot/rsrc/css/phui/calendar/phui-calendar.css

Loading...
Phabricator · Built by Phacility