Page MenuHomePhabricator

Make limits and ranges work better with Calendar event queries
ClosedPublic

Authored by epriestley on Jul 13 2016, 4:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 6, 4:06 AM
Unknown Object (File)
Mon, Dec 2, 8:50 PM
Unknown Object (File)
Mon, Dec 2, 7:27 AM
Unknown Object (File)
Mon, Nov 25, 1:06 PM
Unknown Object (File)
Oct 21 2024, 8:22 AM
Unknown Object (File)
Oct 18 2024, 3:27 PM
Unknown Object (File)
Oct 17 2024, 12:06 AM
Unknown Object (File)
Oct 7 2024, 9:18 AM
Subscribers
None

Details

Summary

Fixes T8911. This corrects several issues which could crop up if a calendar event query matched more results than the query limit:

  • The desired order was not applied by the SearchEngine -- it applies the first builtin order instead. Provide a proper builtin order.
  • When we generate ghosts, we can't do limiting in the database because we may select and then immediately discard a large number of parent events which are outside of the query range.
    • For now, just don't limit results to get the behavior correct.
    • This may need to be refined eventually to improve performance.
  • When trimming events, we could trim parents and fail to generate ghosts from them. Separate parent events out first.
  • Try to simplify some logic.
Test Plan

An "Upcoming" dashboard panel with limit 10 and the main Calendar "Upcoming Events" UI now show the same results.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Make limits and ranges work better with Calendar event queries.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 13 2016, 7:26 PM
This revision was automatically updated to reflect the committed changes.