Page MenuHomePhabricator

Ignore unreachable commits when testing if a repository has imported
ClosedPublic

Authored by epriestley on Jul 11 2016, 3:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 20, 8:20 PM
Unknown Object (File)
Feb 6 2024, 3:13 AM
Unknown Object (File)
Feb 1 2024, 1:16 AM
Unknown Object (File)
Jan 19 2024, 5:54 AM
Unknown Object (File)
Jan 15 2024, 7:46 AM
Unknown Object (File)
Dec 27 2023, 8:27 AM
Unknown Object (File)
Dec 21 2023, 3:39 PM
Unknown Object (File)
Dec 21 2023, 4:03 AM
Subscribers
None

Details

Summary

Fixes T11309. When checking if a repository was fully imported, we incorrectly allow unreachable, un-imported commits to prevent the repository from moving to "Imported".

This can happen if you delete branches from a repository while it is importing.

Instead, ignore unreachable commits when checking for remaining imports, and when reporting status via bin/repository importing.

Test Plan
  • Stopped daemons.
  • Created a new repository and activated it.
  • Ran bin/repository update Rxx.
  • Deleted a branch in the repository.
  • Ran bin/repository update Rxx.
  • Ran daemons to flush queue.

Now:

  • Ran bin/repository importing. Old behavior: showed unreachable commits as importing. New behavior: does not show unreachable commits.
  • Ran bin/repository update. Old behavior: failed to move repository to "imported" status. New behavior: correctly moves repository to "imported" status.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Ignore unreachable commits when testing if a repository has imported.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 11 2016, 3:15 PM
This revision was automatically updated to reflect the committed changes.