Page MenuHomePhabricator

Improve bin/differential attach-commit
Needs RevisionPublic

Authored by isfs on Jul 6 2016, 2:11 AM.
Tags
None
Referenced Files
F14012003: D16239.id39063.diff
Fri, Nov 1, 6:51 AM
F14004694: D16239.diff
Sun, Oct 27, 1:17 AM
F13978884: D16239.id39063.diff
Sat, Oct 19, 1:28 AM
F13955371: D16239.diff
Mon, Oct 14, 1:04 AM
Unknown Object (File)
Wed, Oct 9, 7:37 PM
Unknown Object (File)
Oct 7 2024, 2:01 PM
Unknown Object (File)
Oct 7 2024, 12:51 PM
Unknown Object (File)
Oct 7 2024, 12:12 PM
Subscribers

Details

Summary

Ref T10920, "assigning a diff to a commit post-facto" claimed that "This can be done via the CLI: ./bin/differential attach-commit" but I found when I tried that this wasn't the case.

Although the revision was updated with the commit, it was not actually associated with an edge, so when pushed, the revision wasn't recognised as related to the revision in associated tasks (we do not use arc land).

This diff adjusts attach-commit so it adds the edge, which I believe is what it is expected to do.

Test Plan
  • Created a task
  • Created a diff and associated it to the task
  • Rebased the commit but did not arc diff to update the diff
  • Pushed the commit
  • Used bin/differential attach-commit to attach the commit to the diff
  • Navigated to the task and the commit was correctly shown with the Differential revision beside it in the Commits section (Dxxx / rFOOBAR) rather than having the commit and revision listed separately

Diff Detail

Repository
rP Phabricator
Branch
attach-commit-fix
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12941
Build 16516: arc lint + arc unit

Event Timeline

isfs retitled this revision from to Improve bin/differential attach-commit.
isfs updated this object.
isfs edited the test plan for this revision. (Show Details)
isfs added a reviewer: epriestley.
epriestley edited edge metadata.

The UI now features Edit Related ObjectsEdit Commits.

This revision now requires changes to proceed.Jul 28 2016, 2:29 PM