Page MenuHomePhabricator
Differential D16229

Fix impropery history graph trace in Mercurial
ClosedPublic
Actions

Authored by epriestley on Jul 4 2016, 5:23 PM.
Tags
None
Referenced Files
F19046157: D16229.diff
Thu, Nov 27, 9:39 AM
F19041097: D16229.diff
Wed, Nov 26, 2:36 PM
F18796578: D16229.id39037.diff
Oct 17 2025, 3:47 AM
F18784056: D16229.diff
Oct 13 2025, 11:47 AM
F18772395: D16229.id39039.diff
Oct 9 2025, 2:16 AM
F18733388: D16229.id.diff
Sep 30 2025, 10:33 PM
F18507802: D16229.id.diff
Sep 5 2025, 2:26 AM
F18150158: D16229.id.diff
Aug 14 2025, 6:01 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11267: Commit graph broken for Mercurial repositories
Commits
rP2a1393c008c3: Fix impropery history graph trace in Mercurial
Summary

Fixes T11267. This data was coming back weird (in reverse order relative to the graph itself). Previously it worked OK anyway, but the new logic is a little more sensitive to the input.

Test Plan

Viewed a Mercurial repository with linear history, saw linear history.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 39037.Jul 4 2016, 5:23 PM
epriestley retitled this revision from to Fix impropery history graph trace in Mercurial.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11267: Commit graph broken for Mercurial repositories.
chad accepted this revision.Jul 4 2016, 5:23 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 4 2016, 5:23 PM
Closed by commit rP2a1393c008c3: Fix impropery history graph trace in Mercurial (authored by epriestley, committed by epriestley). · Explain WhyJul 4 2016, 5:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
conduit/
2 lines

Diff 39039

View Options

src/applications/diffusion/conduit/DiffusionHistoryQueryConduitAPIMethod.php

Loading...
Phabricator · Built by Phacility