Correctly disinguish between "0 seconds behind master" and "not replicating"
ClosedPublic
Actions

Authored by epriestley on Jul 3 2016, 9:15 PM.

Details

Reviewers

chad

Maniphest Tasks

T11159: Cluster detection of "replication OK" is unreasonably optimistic

Commits

rP01040e457307: Correctly disinguish between "0 seconds behind master" and "not replicating"

Summary

Fixes T11159. We get two different values here (NULL and 0) with different meanings.

Test Plan

Ran STOP SLAVE;.
Saw this:

Screen Shot 2016-07-03 at 2.12.57 PM.png (336×755 px, 32 KB)

Ran START SLAVE;.
Back to normal.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 39028.Jul 3 2016, 9:15 PM

epriestley retitled this revision from to Correctly disinguish between "0 seconds behind master" and "not replicating".

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11159: Cluster detection of "replication OK" is unreasonably optimistic.

chad accepted this revision.Jul 4 2016, 12:08 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Jul 4 2016, 12:08 AM

Closed by commit rP01040e457307: Correctly disinguish between "0 seconds behind master" and "not replicating" (authored by epriestley, committed by epriestley). · Explain WhyJul 4 2016, 1:14 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

cluster/

PhabricatorDatabaseRef.php

29 lines

Diff 39034

View Options

src/infrastructure/cluster/PhabricatorDatabaseRef.php

Correctly disinguish between "0 seconds behind master" and "not replicating"ClosedPublicActions