Ref T11261, This removes 50/50 and 67/33 layout options for Dashboards. These are universally difficult to read and understand, but are frequently chosen by admins. Reducing options means we can spend more time improving the existing ones.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T11261: Simplify Dashboard Panel Layouts
Build a 50/50 dashboard, apply patch, still able to edit and use dashboard, but option no longer exists to create new ones.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- dashboard-panels (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 12910 Build 16467: Run Core Tests Build 16466: arc lint + arc unit
Event Timeline
Comment Actions
Also, this will prevent you from editing any of these, since as soon as you edit it it will immediately switch to "full" I think.
Comment Actions
Hmm, true, you can't rename a Dashboard, but I don't think there is anything specifically interesting there otherwise?
Comment Actions
Yeah, just surprising if you hit edit, don't change anything, hit save, and accidentally completely broke the dashboard in a way you can't revert.
Comment Actions
You could make a change in PhabricatorDashboardEditController instead, more like this (near line 132):
$layout_mode_options = PhabricatorDashboardLayoutConfig::getLayoutModeSelectOptions(); $legacy = array( PhabricatorDashboardLayoutConfig::MODE_HALF_AND_HALF, PhabricatorDashboardLayoutConfig::MODE_THIRD_AND_THIRDS, ); foreach ($legacy as $legacy_option) { if ($v_layout_mode == $legacy_option) { // Don't remove it if the dashboard is currently set to this value. continue; } unset($layout_mode_options[$legacy_option]); }
Then each option will appear if the dashboard is already set to that value, but not for new dashboards.