Page MenuHomePhabricator

Remove non-useful dashboard layout options
AbandonedPublic

Authored by chad on Jul 2 2016, 6:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 22, 10:44 PM
Unknown Object (File)
Thu, Apr 4, 10:37 AM
Unknown Object (File)
Mar 25 2024, 6:18 PM
Unknown Object (File)
Mar 25 2024, 5:41 PM
Unknown Object (File)
Mar 25 2024, 5:27 PM
Unknown Object (File)
Mar 20 2024, 6:08 PM
Unknown Object (File)
Jan 15 2024, 7:40 PM
Unknown Object (File)
Dec 23 2023, 6:48 PM
Subscribers

Details

Summary

Ref T11261, This removes 50/50 and 67/33 layout options for Dashboards. These are universally difficult to read and understand, but are frequently chosen by admins. Reducing options means we can spend more time improving the existing ones.

Test Plan

Build a 50/50 dashboard, apply patch, still able to edit and use dashboard, but option no longer exists to create new ones.

Diff Detail

Repository
rP Phabricator
Branch
dashboard-panels (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12910
Build 16467: Run Core Tests
Build 16466: arc lint + arc unit

Event Timeline

chad retitled this revision from to Remove non-useful dashboard layout options.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.

This feels like 100% backlash for 0% benefit, but okay.

This revision is now accepted and ready to land.Jul 2 2016, 6:06 PM

Also, this will prevent you from editing any of these, since as soon as you edit it it will immediately switch to "full" I think.

Hmm, true, you can't rename a Dashboard, but I don't think there is anything specifically interesting there otherwise?

Yeah, just surprising if you hit edit, don't change anything, hit save, and accidentally completely broke the dashboard in a way you can't revert.

You could make a change in PhabricatorDashboardEditController instead, more like this (near line 132):

$layout_mode_options = PhabricatorDashboardLayoutConfig::getLayoutModeSelectOptions();

$legacy = array(
  PhabricatorDashboardLayoutConfig::MODE_HALF_AND_HALF,
  PhabricatorDashboardLayoutConfig::MODE_THIRD_AND_THIRDS,
);

foreach ($legacy as $legacy_option) {
  if ($v_layout_mode == $legacy_option) {
    // Don't remove it if the dashboard is currently set to this value.
    continue;
  }
  unset($layout_mode_options[$legacy_option]);
}

Then each option will appear if the dashboard is already set to that value, but not for new dashboards.