Page MenuHomePhabricator

Make the revision graph view more flexible
ClosedPublic

Authored by epriestley on Jul 1 2016, 3:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 7:17 AM
Unknown Object (File)
Thu, Dec 12, 10:35 PM
Unknown Object (File)
Tue, Dec 3, 10:47 PM
Unknown Object (File)
Tue, Dec 3, 1:07 PM
Unknown Object (File)
Wed, Nov 27, 12:16 PM
Unknown Object (File)
Tue, Nov 19, 2:08 PM
Unknown Object (File)
Nov 13 2024, 11:52 AM
Unknown Object (File)
Oct 27 2024, 8:04 AM
Subscribers
None

Details

Summary

Ref T4788. This separates the revision graph view into a base class with core logic and a revision class with Differential-specific logic, so I can subclass it in Maniphest, etc., and try using it in other applications to show similar graphs.

Not sure if we'll stick with it, but even if we don't this makes the code a bit cleaner and gets custom rendering logic out of the RevisionViewController, which is nice.

Test Plan

Viewed revisions, saw the stack UI completely unchanged.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Make the revision graph view more flexible.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 1 2016, 4:40 PM
This revision was automatically updated to reflect the committed changes.