Page MenuHomePhabricator

Refine available filters and defaults for relationship selection
ClosedPublic

Authored by epriestley on Jun 30 2016, 5:56 PM.
Tags
None
Referenced Files
F13059887: D16202.diff
Fri, Apr 19, 4:59 PM
Unknown Object (File)
Tue, Apr 16, 2:51 PM
Unknown Object (File)
Mon, Apr 8, 10:14 AM
Unknown Object (File)
Sun, Apr 7, 2:00 PM
Unknown Object (File)
Feb 18 2024, 10:46 AM
Unknown Object (File)
Feb 18 2024, 10:46 AM
Unknown Object (File)
Feb 18 2024, 10:46 AM
Unknown Object (File)
Feb 12 2024, 12:02 AM
Subscribers
None

Details

Summary

Ref T4788. Fixes T10703.

In the longer term I want to put this on top of ApplicationSearch, but that's somewhat complex and we're at a fairly good point to pause this feature for feedback.

Inch toward that instead: provide more appropriate filters and defaults without rebuilding the underlying engine. Specifically:

  • No "assigned" for commits (barely makes sense).
  • No "assigned" for mocks (does not make sense).
  • Default to "open" for parent tasks, subtasks, close as duplicate, and merge into.

Also, add a key to the search_document table to improve the performance of the "all open stuff of type X" query. "All Open Tasks" is about 100x faster on my machine with this key.

Test Plan
  • Clicked all object relationships, saw more sensible filters and defaults.
  • Saw "open" query about 100x faster locally (300ms to 3ms).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Refine available filters and defualts for relationship selection.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley retitled this revision from Refine available filters and defualts for relationship selection to Refine available filters and defaults for relationship selection.Jun 30 2016, 5:57 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 30 2016, 6:48 PM
This revision was automatically updated to reflect the committed changes.