Page MenuHomePhabricator

Validate Arcanist install-certificate URIs more carefully

Authored by epriestley on Jun 28 2016, 9:45 PM.



Fixes T11222. This was lazy-future-proofed for Conduit SSH support, but users are boundlessly creative. Check protocols explicitly.

Test Plan
$ arc install-certificate a.b:1/
Usage Exception: Server URI "a.b:1/" must include the "http" or "https" protocol. It should be in the form "".
  • Also went through a successful workflow with a URI in the form provided in the example.

Diff Detail

rARC Arcanist
Lint Not Applicable
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Validate Arcanist install-certificate URIs more carefully.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 28 2016, 10:15 PM
This revision was automatically updated to reflect the committed changes.