Validate Arcanist install-certificate URIs more carefully
ClosedPublic
Actions

Authored by epriestley on Jun 28 2016, 9:45 PM.

Details

Reviewers

Maniphest Tasks

T11222: arc hitting wrong url for conduit when not passed a full URI

Commits

rARCf1c45a3323ae: (stable) Promote 2016 Week 27
rARC4d4d16f25985: Validate Arcanist install-certificate URIs more carefully

Summary

Fixes T11222. This was lazy-future-proofed for Conduit SSH support, but users are boundlessly creative. Check protocols explicitly.

Test Plan

$ arc install-certificate a.b:1/
Usage Exception: Server URI "a.b:1/" must include the "http" or "https" protocol. It should be in the form "https://phabricator.example.com/".

Also went through a successful workflow with a URI in the form provided in the example.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38938.Jun 28 2016, 9:45 PM

epriestley retitled this revision from to Validate Arcanist install-certificate URIs more carefully.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11222: arc hitting wrong url for conduit when not passed a full URI.

chad accepted this revision.Jun 28 2016, 10:15 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 28 2016, 10:15 PM

Closed by commit rARC4d4d16f25985: Validate Arcanist install-certificate URIs more carefully (authored by epriestley, committed by epriestley). · Explain WhyJun 28 2016, 10:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistInstallCertificateWorkflow.php

21 lines

Diff 38943

View Options

src/workflow/ArcanistInstallCertificateWorkflow.php

Validate Arcanist install-certificate URIs more carefullyClosedPublicActions