Page MenuHomePhabricator

Remove "re prefix" and "vary subjects" config
ClosedPublic

Authored by epriestley on Jun 14 2016, 6:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 20, 11:32 AM
Unknown Object (File)
Feb 1 2024, 1:36 PM
Unknown Object (File)
Jan 22 2024, 4:14 AM
Unknown Object (File)
Jan 22 2024, 4:14 AM
Unknown Object (File)
Dec 27 2023, 7:31 AM
Unknown Object (File)
Dec 23 2023, 10:50 AM
Unknown Object (File)
Dec 21 2023, 2:02 PM
Unknown Object (File)
Dec 17 2023, 11:13 AM
Subscribers

Details

Summary

Ref T11098. There is no reason to maintain these as separate values now that they can be configured in global settings.

Test Plan
  • Hit and read setup issue.
  • Fiddled with settings.
  • I'll vet this more throughly in the next diff since I need to fix an issue with global defaults in mail and can explicitly test this at the same time.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Remove "re prefix" and "vary subjects" config.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 14 2016, 6:31 PM
epriestley edited edge metadata.
  • Also default "Re Prefix" to "no prefix", which is more consistent with the old behavior.

should there be a migration or is the admin supposed to reconfigure these?

I'll provide guidance in the changelog and you'll get a setup warning, but you should reconfigure them. If you've set both, we can't guess which you mean (and I'd guess 99% of installs use the defaults).

This revision was automatically updated to reflect the committed changes.