Page MenuHomePhabricator

Fix construction of default settings for users with no settings at all
ClosedPublic

Authored by epriestley on Jun 13 2016, 10:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 20, 7:54 PM
Unknown Object (File)
Feb 1 2024, 12:38 PM
Unknown Object (File)
Jan 23 2024, 9:28 AM
Unknown Object (File)
Jan 22 2024, 4:07 AM
Unknown Object (File)
Jan 22 2024, 4:06 AM
Unknown Object (File)
Jan 22 2024, 4:06 AM
Unknown Object (File)
Jan 15 2024, 10:42 PM
Unknown Object (File)
Dec 27 2023, 7:29 AM
Subscribers
None

Details

Summary

Ref T11098. Users with at least one setting set correctly fall back to the defaults, but users with no settings at all currently do not.

Make them fall back to global defaults properly.

Test Plan
  • Set global defaults to some non-default setting.
  • Completely delete a user's settings.
  • bin/cache purge --purge-all or --purge-user.
  • View settings as the user.
    • Before change: showed hard-coded defaults instead of global defaults until you save anything.
    • After change: properly shows global defaults from the start.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix construction of default settings for users with no settings at all.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
  • Very slight simplification.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 13 2016, 10:35 PM
epriestley edited edge metadata.
  • Fix a unit test issue for installs with no global settings.
This revision was automatically updated to reflect the committed changes.