Page MenuHomePhabricator

Improve some typeahead matching behaviors
ClosedPublic

Authored by epriestley on Jun 9 2016, 8:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Aug 18, 1:56 PM
Unknown Object (File)
Tue, Aug 16, 8:29 PM
Unknown Object (File)
Sat, Aug 13, 11:35 AM
Unknown Object (File)
Mon, Aug 8, 12:51 AM
Unknown Object (File)
Thu, Aug 4, 9:46 AM
Unknown Object (File)
Thu, Aug 4, 3:58 AM
Unknown Object (File)
Thu, Aug 4, 3:58 AM
Unknown Object (File)
Thu, Aug 4, 3:22 AM
Subscribers
None

Details

Summary

Ref T8510. Sort prefix matches above non-prefix matches, so that "Ape Discovery" does not match "discovery" better than "Discovery".

Sort functions last.

Rename function internal strings so they don't get over-promoted the prefix-match rules.

Add kind of a hack to get "Project X" sorting above all the "Project X (Milestone 1)" results.

Test Plan

Created "Ape Discovery", "Baboon Discovery", "Chimpanzee Discovery", etc.

Main project now sorts above milestones:

Screen Shot 2016-06-09 at 1.12.25 PM.png (247×467 px, 26 KB)

Prefix matches now sort above other matches:

Screen Shot 2016-06-09 at 1.12.29 PM.png (306×522 px, 27 KB)

Function results (rarely used) are now less prominent:

Screen Shot 2016-06-09 at 1.12.37 PM.png (242×412 px, 29 KB)

Better function results here:

Screen Shot 2016-06-09 at 1.12.42 PM.png (248×425 px, 34 KB)

More function results:

Screen Shot 2016-06-09 at 1.12.50 PM.png (225×377 px, 31 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable