Add Ponder Question mail create receiver
ClosedPublic
Actions

Authored by chad on Jun 8 2016, 8:42 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T11115: Ponder Inbound E-Mail Enhancement

Commits

rPe808963eae75: Add Ponder Question mail create receiver

Summary

Fixes T11115, but unclear how to test this. I think I've asked this in the past.

Test Plan

Visit Applications -> Ponder
Configure external email
Test External Email
See new Question

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 38698.Jun 8 2016, 8:42 PM

chad retitled this revision from to Add Ponder Question mail create receiver.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T11115: Ponder Inbound E-Mail Enhancement.

Herald added a subscriber: Korvin. · View Herald TranscriptJun 8 2016, 8:42 PM

chad edited the test plan for this revision. (Show Details)Jun 8 2016, 8:43 PM

I think you can test this with bin/mail receive-test. Something like this:

phabricator/ $ echo "test" | ./bin/mail receive-test --as chad --to ponder@whatever.com

Give that a shot? We might need to add a --subject flag too, but that should theoretically work. If you don't get anywhere with it, let me know and I'll see if I can fix it so it works.

Code itself looks good to me.

src/applications/ponder/mail/PonderQuestionCreateMailReceiver.php
21	Incredibly minor, but this will prevent creating questions with great titles like "0" and "0.0". Doing `if (!strlen($title))` instead will work for all titles.