Differential D16028

Modernize pinned homepage applications settings
ClosedPublic
Actions

Authored by epriestley on Jun 3 2016, 5:37 PM.

Tags

None

Referenced Files

	F14830347: D16028.diff
	Wed, Jan 29, 8:49 PM

	F14829744: D16028.id38580.diff
	Wed, Jan 29, 5:48 PM

	Unknown Object (File)
	Sun, Jan 26, 5:45 AM

	Unknown Object (File)
	Sat, Jan 25, 10:44 PM

	Unknown Object (File)
	Fri, Jan 24, 6:04 PM

	Unknown Object (File)
	Thu, Jan 23, 3:40 PM

	Unknown Object (File)
	Tue, Jan 21, 10:19 AM

	Unknown Object (File)
	Fri, Jan 17, 11:02 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T4103: Implement "Role Profiles" to provide search, homepage and application defaults

Commits

rP64d6593e9cba: Modernize pinned homepage applications settings

Summary

Ref T4103. A few bits here:

We have an ancient "tiles" preference which was just a fallback from 2-3 years ago. Throw that away.
Modenize the other pinned stuff. We should likely revisit this after the next homepage update but I just left the actual defaults alone for now.
Lightly prepare for global default editing.
Add a "reset to defaults" option.

Test Plan

Pinned, unpinned, reordered and reset application homepage order.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38559.Jun 3 2016, 5:37 PM

epriestley retitled this revision from to Modernize pinned homepage applications settings.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T4103: Implement "Role Profiles" to provide search, homepage and application defaults.

chad accepted this revision.Jun 3 2016, 5:49 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 3 2016, 5:49 PM

Closed by commit rP64d6593e9cba: Modernize pinned homepage applications settings (authored by epriestley, committed by epriestley). · Explain WhyJun 4 2016, 9:42 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

home/

controller/

PhabricatorHomeController.php

5 lines

settings/

panel/

PhabricatorEditEngineSettingsPanel.php

7 lines

PhabricatorHomePreferencesSettingsPanel.php

90 lines

PhabricatorSettingsPanel.php

18 lines

setting/

PhabricatorPinnedApplicationsSetting.php

33 lines

storage/

PhabricatorUserPreferences.php

45 lines

Diff 38580

src/__phutil_library_map__.php

Loading...

src/applications/home/controller/PhabricatorHomeController.php

Loading...

src/applications/settings/panel/PhabricatorEditEngineSettingsPanel.php

Loading...

src/applications/settings/panel/PhabricatorHomePreferencesSettingsPanel.php

Loading...

src/applications/settings/panel/PhabricatorSettingsPanel.php

Loading...

src/applications/settings/setting/PhabricatorPinnedApplicationsSetting.php

Loading...

src/applications/settings/storage/PhabricatorUserPreferences.php

Loading...