Page MenuHomePhabricator

Fix reading ad-hoc settings with no formal Settings object
ClosedPublic

Authored by epriestley on Jun 3 2016, 1:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 20 2024, 10:35 PM
Unknown Object (File)
Feb 20 2024, 10:35 PM
Unknown Object (File)
Feb 20 2024, 10:35 PM
Unknown Object (File)
Feb 20 2024, 9:44 PM
Unknown Object (File)
Feb 3 2024, 10:24 AM
Unknown Object (File)
Jan 31 2024, 1:08 AM
Unknown Object (File)
Jan 26 2024, 1:21 AM
Unknown Object (File)
Jan 8 2024, 5:58 PM
Subscribers
None

Details

Summary

Ref T4103. Some settings (like the collapsed/expanded state of the diff filetree) are currently ad-hoc. They weren't being read correctly.

Also, simplify the caching code a little bit.

Test Plan

Toggled filetree, reloaded page, got sticky behavior.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix reading ad-hoc settings with no formal Settings object.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 3 2016, 5:52 PM
This revision was automatically updated to reflect the committed changes.