Page MenuHomePhabricator

Formalize and fully modularize settings panel groups
ClosedPublic

Authored by epriestley on Jun 3 2016, 12:56 PM.
Tags
None
Referenced Files
F15494091: D16020.id38551.diff
Sat, Apr 12, 10:33 PM
F15481461: D16020.id38551.diff
Tue, Apr 8, 8:54 PM
F15479678: D16020.id38551.diff
Tue, Apr 8, 8:41 AM
F15456830: D16020.diff
Sun, Mar 30, 12:26 PM
F15456686: D16020.diff
Sun, Mar 30, 11:22 AM
F15456657: D16020.diff
Sun, Mar 30, 11:06 AM
F15451751: D16020.id38572.diff
Fri, Mar 28, 11:38 PM
F15450125: D16020.id.diff
Fri, Mar 28, 2:08 PM
Subscribers
None

Details

Summary

Ref T4103. Settings panels are grouped into categories of similar panels (like "Email" or "Sessions and Logs").

Currently, this is done informally, by just grouping and ordering by strings. This won't work well with translations, since it means the ordering is entirely dependent on the language order, so the first settings panel you see might be something irrelvant or confusing. We'd also potentially break third-party stuff by changing strings, but do so in a silent hard-to-detect way.

Provide formal objects and modularize the panel groups completely.

Test Plan

Verified all panels still appear properly and in the same groups and order.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Formalize and fully modularize settings panel groups.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 3 2016, 2:58 PM
This revision was automatically updated to reflect the committed changes.