Page MenuHomePhabricator

When a user changes their timezone, clear their ignored timezone offset
ClosedPublic

Authored by epriestley on Jun 3 2016, 12:24 PM.

Details

Summary

Ref T4103. We have a couple of settings like this where changing one setting changes another (e.g., enabling DarkConsole makes the console visible).

Provide a mechanism to let changing timezone really mean "change timezone, and also clear the timezone offset".

Test Plan

Swapped timezones, reconciled them by ignoring the offset, changed timezone again to another zone with the same offset, got asked to reconcile again.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley retitled this revision from to When a user changes their timezone, clear their ignored timezone offset.Jun 3 2016, 12:24 PM
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley updated this revision to Diff 38548.
chad edited edge metadata.Jun 3 2016, 2:51 PM
chad accepted this revision.
This revision is now accepted and ready to land.Jun 3 2016, 2:51 PM
This revision was automatically updated to reflect the committed changes.