Page MenuHomePhabricator

Convert some loadPreferences() to getUserSetting()
ClosedPublic

Authored by epriestley on Jun 1 2016, 9:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 5, 6:01 PM
Unknown Object (File)
Feb 3 2024, 10:21 AM
Unknown Object (File)
Jan 23 2024, 2:44 AM
Unknown Object (File)
Dec 27 2023, 7:14 AM
Unknown Object (File)
Dec 27 2023, 7:14 AM
Unknown Object (File)
Dec 24 2023, 3:02 AM
Unknown Object (File)
Dec 21 2023, 1:50 PM
Unknown Object (File)
Dec 21 2023, 1:50 PM
Subscribers
None

Details

Summary

Ref T4103. This doesn't get everything, but takes care of most of the easy stuff.

The tricky-ish bit here is that I need to move timezones, pronouns and translations to proper settings. I expect to pursue that next.

Test Plan
  • Grepped for loadPreferences to identify callsites.
  • Changed start-of-week setting, loaded Calendar, saw correct start.
  • Visited welcome page, read "Adjust Settings" point.
  • Loaded Conpherence -- I changed behavior here slightly (switching threads drops the title glyph) but it wasn't consistent to start with and this seems like a good thing to push to the next version of Conpherence.
  • Enabled Filetree, toggled in Differential.
  • Disabled Filetree, no longer visible in Differential.
  • Changed "Unified Diffs" preference to "Small Screens" vs "Always".
  • Toggled filetree in Diffusion.
  • Edited a task, saw sensible projects in policy dropdown.
  • Viewed user profile, uncollapsed/collapsed side nav, reloaded page, sticky'd.
  • Toggled "monospaced textareas", used a comment box, got appropriate fonts.
  • Toggled durable column.
  • Disabled title glyphs.
  • Changed monospaced font to 18px/36px impact.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Convert some loadPreferences() to getUserSetting().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 1 2016, 9:21 PM
This revision was automatically updated to reflect the committed changes.