Page MenuHomePhabricator

Modularize all straightforward settings
ClosedPublic

Authored by epriestley on Jun 1 2016, 5:26 PM.
Tags
None
Referenced Files
F13059749: D15999.diff
Fri, Apr 19, 4:45 PM
Unknown Object (File)
Wed, Apr 10, 12:23 AM
Unknown Object (File)
Mon, Apr 1, 5:18 PM
Unknown Object (File)
Sun, Mar 31, 1:09 AM
Unknown Object (File)
Sat, Mar 30, 2:03 AM
Unknown Object (File)
Sun, Mar 24, 10:52 PM
Unknown Object (File)
Thu, Mar 21, 10:28 PM
Unknown Object (File)
Mar 16 2024, 3:19 AM
Subscribers
None

Details

Summary

Ref T4103. This tackles all the easy stuff. Not yet handled:

  • Translation, pronoun, timezone: these are weird and stored on the User object instead of in settings.
  • Conpherence default: actually just missed this one, it's normal.
  • 1000 dropdowns for email notification preferences (messy, technically).
Test Plan

wow look at all these settings

Screen Shot 2016-06-01 at 10.10.46 AM.png (1×1 px, 344 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Modularize all straightforward settings.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

Is there no grouping anymore?

chad edited edge metadata.
This revision is now accepted and ready to land.Jun 1 2016, 6:01 PM

I just haven't written the grouping part yet. I'm doing one huge form first to make sure all the controls work, then I'll deal with grouping stuff.

This revision was automatically updated to reflect the committed changes.