Page MenuHomePhabricator

Convert "Display Preferences" to modular settings
ClosedPublic

Authored by epriestley on May 31 2016, 11:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 25, 12:17 AM
Unknown Object (File)
Sun, Mar 24, 10:51 PM
Unknown Object (File)
Sun, Mar 24, 10:51 PM
Unknown Object (File)
Sun, Mar 24, 8:39 PM
Unknown Object (File)
Sun, Mar 24, 2:11 PM
Unknown Object (File)
Thu, Mar 21, 9:10 PM
Unknown Object (File)
Thu, Mar 21, 6:42 PM
Unknown Object (File)
Thu, Mar 21, 12:59 AM
Subscribers
None

Details

Summary

Ref T4103. Just porting these directly for now, no attempt to organize things yet.

Test Plan

Screen Shot 2016-05-31 at 4.47.54 PM.png (1×1 px, 263 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Convert "Display Preferences" to modular settings.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.

oh man... designer, stat!

This revision is now accepted and ready to land.Jun 1 2016, 3:57 AM

Yeah -- I'm not totally sure what I'm going to do to replace the current UI. A lot of the panels need to stay pretty much the same: we can't really replace any of the table/log panels like "Sessions" or "Temporary Tokens" or "Conduit API Tokens" or "Activity Logs" with EditEngine, since the content of those panels isn't forms.

Beyond that, I can stick with a pretty faithful version of the current UI, or we can try to reorganize things a bit. One thing I don't particularly like about the current UI is the "Save -> redirect to same page with ?saved=true -> show a confirmation" flow, but I don't have any real concrete reason not to keep doing that (and I can make it a little prettier, like /saved/), it just feels a little messy.

We could do something a little more like Diffusion where the main panel is a view panel and then you click an "Edit This Stuff" link to get to the form version, but that seems worse here, at least at first glance.

A lot of these controls also have a bunch of explanatory text which is pretty hard to read already (and moreso in this giant one-page version), and looking worse with a more consistent presentation (some of it was half-hidden in captions, etc., before, so it had less visible impact). I think this text is generally pretty important: the meaning of most of these options is not self-evident. But I'm not sure if we can find a better way to present it.

I'm planning to finish converting stuff before tackling this, though, in any case.

(Fixing the huge text might just be an issue of putting spacers or beefier margins between the settings, I haven't played with it yet.)

This revision was automatically updated to reflect the committed changes.