Page MenuHomePhabricator

Make Settings modular and allow them to be EditEngine'd
ClosedPublic

Authored by epriestley on May 31 2016, 8:59 PM.
Tags
None
Referenced Files
F18598088: D15995.diff
Sat, Sep 13, 4:19 AM
F18588717: D15995.diff
Fri, Sep 12, 1:17 AM
F18500201: D15995.diff
Thu, Sep 4, 8:35 PM
F18487056: D15995.diff
Wed, Sep 3, 7:12 PM
F18235751: D15995.diff
Wed, Aug 20, 7:44 PM
F18045573: D15995.id38501.diff
Aug 3 2025, 9:16 AM
F18036065: D15995.id38500.diff
Aug 3 2025, 1:47 AM
F17954518: D15995.id38501.diff
Aug 1 2025, 4:06 AM
Subscribers
None

Details

Summary

Ref T4103. This starts breaking out settings in a modern way to prepare for global defaults.

Test Plan
  • Edited diff settings.
  • Saw them take effect in primary settings pane.
  • Set stuff to new automatic defaults.
  • Tried to edit another user's settings.
  • Edited a bot's settings as an administrator.

Screen Shot 2016-05-31 at 1.54.04 PM.png (973×1 px, 159 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Make Settings modular and allow them to be EditEngine'd.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.May 31 2016, 9:11 PM
This revision was automatically updated to reflect the committed changes.