Add role=dialog to all dialogs
ClosedPublic
Actions

Authored by chad on May 31 2016, 7:20 PM.

Tags

None

Referenced Files

	F18747346: D15993.id38495.diff
	Fri, Oct 3, 3:44 PM

	F18705364: D15993.diff
	Sun, Sep 28, 10:58 AM

	F18688518: D15993.id.diff
	Fri, Sep 26, 4:37 PM

	F18671249: D15993.diff
	Thu, Sep 25, 3:13 AM

	F18671128: D15993.id.diff
	Thu, Sep 25, 2:46 AM

	F18611641: D15993.id38496.diff
	Sep 14 2025, 7:30 AM

	F18595121: D15993.id38496.diff
	Sep 12 2025, 8:29 PM

	F18593567: D15993.diff
	Sep 12 2025, 3:16 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rPb23c85b16915: Add role=dialog to all dialogs

Summary

Seen some complaints about usability here, adding role=dialog to improve when these trigger.

Test Plan

Turn on Voiceover, tab over to log out link, here proper dialog title and text before highlighted submit button.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 38495.May 31 2016, 7:20 PM

chad retitled this revision from to Add role=dialog to all dialogs.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptMay 31 2016, 7:20 PM

epriestley accepted this revision.May 31 2016, 7:20 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 31 2016, 7:20 PM

Closed by commit rPb23c85b16915: Add role=dialog to all dialogs (authored by chad, committed by chad). · Explain WhyMay 31 2016, 7:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

view/

AphrontDialogView.php

1 line

Diff 38496

View Options

src/view/AphrontDialogView.php

Add role=dialog to all dialogsClosedPublicActions