Page MenuHomePhabricator

Add role=dialog to all dialogs
ClosedPublic

Authored by chad on May 31 2016, 7:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 21 2024, 7:31 AM
Unknown Object (File)
Feb 14 2024, 11:35 PM
Unknown Object (File)
Feb 14 2024, 3:56 AM
Unknown Object (File)
Feb 14 2024, 3:45 AM
Unknown Object (File)
Jan 27 2024, 4:36 AM
Unknown Object (File)
Jan 16 2024, 5:28 PM
Unknown Object (File)
Dec 17 2023, 5:11 AM
Unknown Object (File)
Dec 9 2023, 11:39 PM
Subscribers

Details

Summary

Seen some complaints about usability here, adding role=dialog to improve when these trigger.

Test Plan

Turn on Voiceover, tab over to log out link, here proper dialog title and text before highlighted submit button.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Add role=dialog to all dialogs.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 31 2016, 7:20 PM
This revision was automatically updated to reflect the committed changes.