Page MenuHomePhabricator

Fix some issues with the "Explain Why" dialog
ClosedPublic

Authored by epriestley on May 30 2016, 4:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 4:39 PM
Unknown Object (File)
Thu, Apr 11, 9:40 AM
Unknown Object (File)
Wed, Apr 10, 3:24 AM
Unknown Object (File)
Sun, Apr 7, 2:05 AM
Unknown Object (File)
Sun, Mar 31, 11:36 PM
Unknown Object (File)
Sun, Mar 31, 11:36 PM
Unknown Object (File)
Sun, Mar 31, 11:36 PM
Unknown Object (File)
Sun, Mar 31, 11:36 PM
Subscribers
None

Details

Summary

Ref T11051. This is still not as clear as it should be, but is at least working as intended now.

I believe this part of the code just never worked. The test plan on D10489 didn't specifically cover it.

Test Plan

Did this sort of thing in a repository:

$ git checkout -b featurex
$ echo x >> y
$ git commit -am wip
$ arc diff

Then I simulated just pushing it (this flow is a little more involved than necessary):

$ arc land --hold
$ git commit --amend
$ # remove all metadata -- particularly, "Differential Revision"!
$ git push HEAD:master

I got a not-great but more-useful dialog:

Screen Shot 2016-05-30 at 9.12.51 AM.png (442×1 px, 59 KB)

Prior to this change, the hash match was incorrectly not reported at all.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix some issues with the "Explain Why" dialog.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.May 30 2016, 4:29 PM
This revision was automatically updated to reflect the committed changes.