Page MenuHomePhabricator
Differential D15969

Fix a possible fatal on the first push to a cluster repository
ClosedPublic
Actions

Authored by epriestley on May 24 2016, 12:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 10:54 PM
Unknown Object (File)
Tue, Dec 17, 4:52 AM
Unknown Object (File)
Thu, Dec 12, 10:37 PM
Unknown Object (File)
Wed, Dec 11, 8:13 AM
Unknown Object (File)
Sat, Dec 7, 11:45 AM
Unknown Object (File)
Tue, Dec 3, 8:02 PM
Unknown Object (File)
Wed, Nov 27, 2:21 PM
Unknown Object (File)
Tue, Nov 19, 12:58 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11020: Pushing to an unactivated cluster repository can freeze the repository in a locked state?
Commits
rP9f399247b1b1: (stable) Fix a possible fatal on the first push to a cluster repository
rPbb16a1b0e2a8: Fix a possible fatal on the first push to a cluster repository
Summary

Fixes T11020. I think this resolves things -- $new_version (set above) should be used, not $new_log directly.

Specifically, we would get into trouble if the initial push failed for some reason (working copy not initialized yet, commit hook rejected, etc).

Test Plan

Made a bad push to a new repository. Saw it freeze before the patch and succeed afterwards.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38446.May 24 2016, 12:15 AM
epriestley retitled this revision from to Fix a possible fatal on the first push to a cluster repository.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11020: Pushing to an unactivated cluster repository can freeze the repository in a locked state?.
chad accepted this revision.May 24 2016, 12:53 AM
chad edited edge metadata.
This revision is now accepted and ready to land.May 24 2016, 12:53 AM
Closed by commit rPbb16a1b0e2a8: Fix a possible fatal on the first push to a cluster repository (authored by epriestley, committed by epriestley). · Explain WhyMay 24 2016, 12:54 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
protocol/
2 lines

Diff 38449

View Options

src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php

Loading...
Phabricator · Built by Phacility