Paths

Table of Contentst

Differential D15962

When the JS "Intl" API is available, use it to guess the timezone
ClosedPublic
Actions

Authored by epriestley on May 22 2016, 1:57 PM.

Details

Reviewers

chad

Maniphest Tasks

T3025: Detect when browser and account timezone settings differ and prompt user to reconcile them

Commits

rP2a00f185eb2f: When the JS "Intl" API is available, use it to guess the timezone

Summary

Ref T3025. Chrome gives us an easily-accessible, much better guess at which timezone the user is in.

Firefox also exposes "Intl" but this doesn't seem to be a reliable method to read the timezone.

Test Plan

In Chrome, swapped my system date/time between zones, clicked the "reconcile" popup, got the dropdown prefilled accurately.

In Safari (no Intl API) got the normal flow with no default selected.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38430.May 22 2016, 1:57 PM

epriestley retitled this revision from to When the JS "Intl" API is available, use it to guess the timezone.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T3025: Detect when browser and account timezone settings differ and prompt user to reconcile them.

epriestley mentioned this in T3025: Detect when browser and account timezone settings differ and prompt user to reconcile them.May 22 2016, 2:04 PM

chad accepted this revision.May 22 2016, 2:28 PM

chad edited edge metadata.

This revision is now accepted and ready to land.May 22 2016, 2:28 PM

Closed by commit rP2a00f185eb2f: When the JS "Intl" API is available, use it to guess the timezone (authored by epriestley, committed by epriestley). · Explain WhyMay 22 2016, 4:14 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T11456: Don't lose user in NUX flow because of Timezone issues.Jul 29 2017, 12:40 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

16 lines

src/

applications/

settings/

controller/

PhabricatorSettingsTimezoneController.php

10 lines

webroot/

rsrc/

js/

core/

behavior-detect-timezone.js

12 lines

Diff 38431

View Options

resources/celerity/map.php

View Options

src/applications/settings/controller/PhabricatorSettingsTimezoneController.php

View Options

webroot/rsrc/js/core/behavior-detect-timezone.js

When the JS "Intl" API is available, use it to guess the timezoneClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 38431

resources/celerity/map.php

src/applications/settings/controller/PhabricatorSettingsTimezoneController.php

webroot/rsrc/js/core/behavior-detect-timezone.js

When the JS "Intl" API is available, use it to guess the timezone
ClosedPublic
Actions

Revision Contents
Changeset List