Page MenuHomePhabricator
Differential D15962

When the JS "Intl" API is available, use it to guess the timezone
ClosedPublic
Actions

Authored by epriestley on May 22 2016, 1:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 5:49 AM
Unknown Object (File)
Fri, Dec 13, 3:03 PM
Unknown Object (File)
Fri, Dec 13, 7:00 AM
Unknown Object (File)
Thu, Dec 12, 10:37 PM
Unknown Object (File)
Thu, Dec 12, 10:36 PM
Unknown Object (File)
Thu, Dec 12, 10:36 PM
Unknown Object (File)
Thu, Dec 12, 10:36 PM
Unknown Object (File)
Mon, Dec 9, 2:39 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T3025: Detect when browser and account timezone settings differ and prompt user to reconcile them
Commits
rP2a00f185eb2f: When the JS "Intl" API is available, use it to guess the timezone
Summary

Ref T3025. Chrome gives us an easily-accessible, much better guess at which timezone the user is in.

Firefox also exposes "Intl" but this doesn't seem to be a reliable method to read the timezone.

Test Plan

In Chrome, swapped my system date/time between zones, clicked the "reconcile" popup, got the dropdown prefilled accurately.

In Safari (no Intl API) got the normal flow with no default selected.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
resources/
celerity/
16 lines
src/
applications/
settings/
controller/
10 lines
webroot/
rsrc/
js/
core/
12 lines

Diff 38431

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/settings/controller/PhabricatorSettingsTimezoneController.php

Loading...
View Options

webroot/rsrc/js/core/behavior-detect-timezone.js

Loading...
Phabricator · Built by Phacility