Page MenuHomePhabricator

Provide an `<input type="file">` control in Remarkup for mobile and users with esoteric windowing systems
ClosedPublic

Authored by epriestley on May 20 2016, 2:35 PM.

Details

Summary

Ref T5187. This definitely feels a bit flimsy and I'm going to hold it until I cut the release since it changes a couple of things about Workflow in general, but it seems to work OK and most of it is fine.

The intent is described in T5187#176236.

In practice, most of that works like I describe, then the phui-file-upload behavior gets some weird glue to figure out if the input is part of the form. Not the most elegant system, but I think it'll hold until we come up with many reasons to write a lot more Javascript.

Test Plan

Used both drag-and-drop and the upload dialog to upload files in Safari, Firefox and Chrome.

Screen Shot 2016-05-20 at 7.33.38 AM.png (1×1 px, 158 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Provide an `<input type="file">` control in Remarkup for mobile and users with esoteric windowing systems.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.May 20 2016, 3:54 PM
This revision was automatically updated to reflect the committed changes.