Page MenuHomePhabricator

Send forced mail on SSH key edits
ClosedPublic

Authored by epriestley on May 19 2016, 6:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 12, 10:03 PM
Unknown Object (File)
Jul 27 2022, 9:41 PM
Unknown Object (File)
Jul 13 2022, 9:30 PM
Unknown Object (File)
Jul 5 2022, 6:28 AM
Unknown Object (File)
Jul 4 2022, 2:50 PM
Unknown Object (File)
Jul 2 2022, 11:52 PM
Unknown Object (File)
Jul 2 2022, 10:38 PM
Unknown Object (File)
Jul 2 2022, 10:37 PM
Subscribers
None

Details

Summary

Ref T10917. This cheats fairly heavily to generate SSH key mail:

  • Generate normal transaction mail.
  • Force it to go to the user.
  • Use setForceDelivery() to force it to actually be delivered.
  • Add some warning language to the mail body.

This doesn't move us much closer to Glorious Infrastructure for this whole class of events, but should do what it needs to for now and doesn't really require anything sketchy.

Test Plan

Created and edited SSH keys, got security notice mail.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Send forced mail on SSH key edits.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.May 19 2016, 9:57 PM
This revision was automatically updated to reflect the committed changes.