Page MenuHomePhabricator
Differential D15933

Allow blocking reviewers to be added via the web UI
ClosedPublic
Actions

Authored by epriestley on May 17 2016, 12:19 AM.
Tags
None
Referenced Files
F15437006: D15933.diff
Tue, Mar 25, 5:00 PM
F15415946: D15933.diff
Thu, Mar 20, 8:30 AM
F15374951: D15933.id38371.diff
Mar 12 2025, 8:50 PM
F15297178: D15933.diff
Mar 5 2025, 12:01 PM
Unknown Object (File)
Mar 3 2025, 5:21 AM
Unknown Object (File)
Feb 28 2025, 11:21 PM
Unknown Object (File)
Feb 9 2025, 9:41 PM
Unknown Object (File)
Feb 9 2025, 1:37 AM
View All Files
Subscribers
scode
Tokens
"Like" token, awarded by Luke081515.2.

Details

Reviewers
chad
Maniphest Tasks
T10939: Support for OWNERS files
Commits
rPafec01129a09: Allow blocking reviewers to be added via the web UI
Summary

Ref T10939. Adds a blocking(...) token.

This code is pretty iffy and going to get worse before it gets better, but the fix (T10967 + EditEngine) is going to be a fair chunk of work down the road.

Test Plan

Screen Shot 2016-05-16 at 5.15.09 PM.png (181×1 px, 33 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38364.May 17 2016, 12:19 AM
epriestley retitled this revision from to Allow blocking reviewers to be added via the web UI.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10939: Support for OWNERS files.
Luke081515.2 awarded a token.May 17 2016, 1:14 AM
epriestley mentioned this in T10939: Support for OWNERS files.May 17 2016, 12:36 PM
scode added a subscriber: scode.May 17 2016, 3:14 PM
chad accepted this revision.May 17 2016, 4:29 PM
chad edited edge metadata.
This revision is now accepted and ready to land.May 17 2016, 4:29 PM
Closed by commit rPafec01129a09: Allow blocking reviewers to be added via the web UI (authored by epriestley, committed by epriestley). · Explain WhyMay 17 2016, 5:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 38371

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/customfield/DifferentialReviewersField.php

Loading...
View Options

src/applications/differential/typeahead/DifferentialBlockingReviewerDatasource.php

Loading...
View Options

src/applications/differential/typeahead/DifferentialReviewerDatasource.php

Loading...
View Options

src/applications/differential/view/DifferentialAddCommentView.php

Loading...
Phabricator · Built by Phacility