Page MenuHomePhabricator

Improve HTML mail rendering of inline patches
ClosedPublic

Authored by epriestley on May 12 2016, 5:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jun 22, 5:49 PM
Unknown Object (File)
Wed, Jun 15, 1:14 AM
Unknown Object (File)
Tue, Jun 14, 3:10 AM
Unknown Object (File)
Sun, Jun 12, 10:10 AM
Unknown Object (File)
Sat, Jun 11, 11:10 PM
Unknown Object (File)
Sat, Jun 11, 11:10 AM
Unknown Object (File)
Sat, Jun 11, 9:48 AM
Unknown Object (File)
May 24 2022, 1:05 PM
Subscribers
None

Details

Summary

Fixes T9790. This uses a simple renderer, like the inline context renderer, that emphasizes getting a quick glance at small changes and working reasonably on mobile devices.

Test Plan
  • Set inline setting to 9999.
  • Created a diff.
  • Saw it render reasonably in HTML mail.
  • Also tested text mail to make sure I didn't break that.

Screen Shot 2016-05-12 at 10.47.39 AM.png (1×1 px, 207 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Improve HTML mail rendering of inline patches.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
chad added inline comments.
src/applications/differential/editor/DifferentialTransactionEditor.php
1449

maybe 6px 0 12px 0.

This revision is now accepted and ready to land.May 12 2016, 7:04 PM
epriestley edited edge metadata.
  • Tighten up top margins a hair.
This revision was automatically updated to reflect the committed changes.