Fix improper viewer for Git SSH cluster workflows
ClosedPublic
Actions

Authored by epriestley on May 12 2016, 12:03 AM.

Details

Reviewers

chad

Maniphest Tasks

T10751: Make Phabricator Highly Available

Commits

rP15f14d6c2f20: Fix improper viewer for Git SSH cluster workflows

Summary

Ref T10751. These workflows have separate getUser() and getViewer() for weird legacy reasons. getUser() is correct.

Test Plan

Did a Git SSH push, verified that "Last Writer" reflected the proper user in the "Storage" UI in repository management.
Grepped for other callsites, double-checked that they used correct users.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38282.May 12 2016, 12:03 AM

epriestley retitled this revision from to Fix improper viewer for Git SSH cluster workflows.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10751: Make Phabricator Highly Available.

Specifically, this fixes the bad "Last Writer" column visible here:

Screen Shot 2016-05-11 at 4.39.13 PM.png (989×1 px, 136 KB)

chad accepted this revision.May 12 2016, 12:47 AM

chad edited edge metadata.

This revision is now accepted and ready to land.May 12 2016, 12:47 AM

Closed by commit rP15f14d6c2f20: Fix improper viewer for Git SSH cluster workflows (authored by epriestley, committed by epriestley). · Explain WhyMay 12 2016, 1:02 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

ssh/

DiffusionGitReceivePackSSHWorkflow.php

2 lines

Diff 38286

View Options

src/applications/diffusion/ssh/DiffusionGitReceivePackSSHWorkflow.php

Fix improper viewer for Git SSH cluster workflowsClosedPublicActions