Allow the default Remarkup tag to be inline-styled for mail
ClosedPublic
Actions

Authored by epriestley on May 6 2016, 12:39 AM.

Details

Reviewers

chad

Maniphest Tasks

T10694: Improve behavior of context for inline comments in mail

Commits

rPHU5d47fb1027f5: Allow the default Remarkup tag to be inline-styled for mail

Summary

Ref T10694. Browsers / mail clients have default  rules, particularly margin/padding. This allows the inline stuff to turn them off with explicit "padding: 0; margin: 0;" so it can control spacing more precisely.

Test Plan

See D15857.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38200.May 6 2016, 12:39 AM

epriestley retitled this revision from to Allow the default Remarkup tag to be inline-styled for mail.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10694: Improve behavior of context for inline comments in mail.

chad accepted this revision.May 6 2016, 2:46 AM

chad edited edge metadata.

This revision is now accepted and ready to land.May 6 2016, 2:46 AM

Closed by commit rPHU5d47fb1027f5: Allow the default Remarkup tag to be inline-styled for mail (authored by epriestley, committed by epriestley). · Explain WhyMay 6 2016, 3:48 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

markup/

engine/

remarkup/

blockrule/

PhutilRemarkupDefaultBlockRule.php

15 lines

Diff 38209

View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupDefaultBlockRule.php

Allow the default Remarkup <p> tag to be inline-styled for mailClosedPublicActions