Produce a more defensible HTML mail rendering of Remarkup blockquotes
ClosedPublic
Actions

Authored by epriestley on May 5 2016, 7:28 PM.

Details

Reviewers

Maniphest Tasks

T7031: Blockquote formatting in HTML mail could be improved
T10694: Improve behavior of context for inline comments in mail

Commits

rPHUd4e36c61b1ac: Produce a more defensible HTML mail rendering of Remarkup blockquotes

Summary

Ref T10694. Fixes T7031. We don't currently put any inline styles on <blockquote> tags produced by prefixing blocks with > in Remarkup.

Add some styles.

Test Plan

Generated some reasonable mail with complex blockquote elements:

Screen Shot 2016-05-05 at 12.26.34 PM.png (1×1 px, 249 KB)

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38195.May 5 2016, 7:28 PM

epriestley retitled this revision from to Produce a more defensible HTML mail rendering of Remarkup blockquotes.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T10694: Improve behavior of context for inline comments in mail, T7031: Blockquote formatting in HTML mail could be improved.

chad accepted this revision.May 5 2016, 7:29 PM

chad edited edge metadata.

This revision is now accepted and ready to land.May 5 2016, 7:29 PM

Closed by commit rPHUd4e36c61b1ac: Produce a more defensible HTML mail rendering of Remarkup blockquotes (authored by epriestley, committed by epriestley). · Explain WhyMay 5 2016, 7:34 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

markup/

engine/

remarkup/

blockrule/

PhutilRemarkupQuotesBlockRule.php

16 lines

Diff 38196

View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupQuotesBlockRule.php

Produce a more defensible HTML mail rendering of Remarkup blockquotesClosedPublicActions