Paths

Table of Contentst

Differential D15848

Pass the new default syntax highlighting map to the remarkup engine
ClosedPublic
Actions

Authored by epriestley on May 5 2016, 2:01 AM.

Details

Reviewers

chad

Maniphest Tasks

T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments

Commits

rP19aac8e8d3be: Pass the new default syntax highlighting map to the remarkup engine

Summary

Ref T9790. This passes the map down so we can generate highlighted mail.

Test Plan

Generated this relatively respectable-looking HTML mail:

Screen Shot 2016-05-04 at 7.00.10 PM.png (1×2 px, 262 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38176.May 5 2016, 2:01 AM

epriestley retitled this revision from to Pass the new default syntax highlighting map to the remarkup engine.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments.

chad accepted this revision.May 5 2016, 3:14 AM

chad edited edge metadata.

This revision is now accepted and ready to land.May 5 2016, 3:14 AM

Also make the special lang=rainbow work properly.

Closed by commit rP19aac8e8d3be: Pass the new default syntax highlighting map to the remarkup engine (authored by epriestley, committed by epriestley). · Explain WhyMay 5 2016, 9:51 AM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T10694: Improve behavior of context for inline comments in mail.May 5 2016, 6:55 PM

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

markup/

PhabricatorMarkupEngine.php

4 lines

syntax/

PhabricatorSyntaxStyle.php

14 lines

Diff 38185

View Options

src/infrastructure/markup/PhabricatorMarkupEngine.php