Page MenuHomePhabricator

Fix a Harbormaster build issue with new URI code
ClosedPublic

Authored by epriestley on May 4 2016, 11:30 PM.
Tags
None
Referenced Files
F18733334: D15844.id.diff
Tue, Sep 30, 10:32 PM
F18720924: D15844.id.diff
Mon, Sep 29, 7:55 PM
F18709371: D15844.diff
Mon, Sep 29, 12:03 AM
F18704998: D15844.id38171.diff
Sun, Sep 28, 9:41 AM
F18658242: D15844.diff
Tue, Sep 23, 5:28 AM
F18625093: D15844.diff
Mon, Sep 15, 9:57 PM
F18622259: D15844.id38171.diff
Mon, Sep 15, 10:59 AM
F18616891: D15844.id.diff
Sun, Sep 14, 7:24 PM
Subscribers
None

Details

Summary

Ref T10748. We're returning a PhabricatorRepositoryURI here but the code expects an actual PhutilURI.

Test Plan

This should clear this up in production:

Daemon 180278 STDE [Wed, 04 May 2016 23:25:16 +0000] [2016-05-04 23:25:16] EXCEPTION: (PhutilProxyException) Error while executing Task ID 1677075. {>} (RuntimeException) Object of class PhabricatorRepositoryURI could not be converted to string at [<phutil>/src/error/PhutilErrorHandler.php:205]
Daemon 180278 STDE [Wed, 04 May 2016 23:25:16 +0000] arcanist(head=master, ref.master=c58f1b9a2507), libcore(), phabricator(head=master, ref.master=29d1115037b8), phutil(head=master, ref.master=0709cd5cfc26), services(head=master, ref.master=04ae8c8f8e3b)
Daemon 180278 STDE [Wed, 04 May 2016 23:25:16 +0000]   #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer, array) called at [<phabricator>/src/applications/repository/storage/PhabricatorRepository.php:1200]
Daemon 180278 STDE [Wed, 04 May 2016 23:25:16 +0000]   #1 <#2> PhabricatorRepository::getPublicCloneURI() called at [<phabricator>/src/applications/repository/storage/PhabricatorRepositoryCommit.php:395]

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix a Harbormaster build issue with new URI code.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.May 4 2016, 11:43 PM
This revision was automatically updated to reflect the committed changes.

This appears to have worked correctly.