Page MenuHomePhabricator

Split Repository EditEngine form into smaller pages
ClosedPublic

Authored by epriestley on May 2 2016, 12:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 24, 9:52 AM
Unknown Object (File)
Fri, Mar 15, 1:32 PM
Unknown Object (File)
Wed, Mar 13, 5:31 AM
Unknown Object (File)
Sun, Mar 10, 9:30 PM
Unknown Object (File)
Feb 10 2024, 11:07 PM
Unknown Object (File)
Feb 9 2024, 6:55 PM
Unknown Object (File)
Feb 6 2024, 8:19 PM
Unknown Object (File)
Jan 29 2024, 8:41 PM
Subscribers
None

Details

Summary

Ref T10748. This allows an EditEngine form to be broken up into pages.

This is less powerful than PHUIPagedFormView, because the pages are not sequential / stateful. Each form saves immediately once it's submitted, and can not take you to a new form or back/forward in a series of forms.

For example, you can't create a workflow where the user fills out 5 pages of information before we create an object, like the current repository workflow does.

However, the only place we've ever wanted to do this is repositories and it's fairly bad there, so I feel reasonably confident we aren't going to miss this in the future.

(We do "choose a type of service/repository/rule -> fill out one page of info" fairly often, but can do this without the full-power paging stuff.)

Test Plan
  • Created a repository usin the new Manage UI, filling out only a handful of fields.
  • Edited a repository using the new Manage UI.
  • All forms are now EditEngine forms offering paged views of the big huge underlying form:

Screen Shot 2016-05-02 at 5.39.15 AM.png (1×1 px, 127 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Split Repository EditEngine form into smaller pages.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.May 2 2016, 2:09 PM
This revision was automatically updated to reflect the committed changes.