Page MenuHomePhabricator
Differential D15824

Alternate fix for Firefox triple click selection
ClosedPublic
Actions

Authored by epriestley on Apr 29 2016, 11:56 PM.
Tags
None
Referenced Files
F14852207: D15824.id38123.diff
Tue, Feb 4, 11:03 PM
Unknown Object (File)
Wed, Jan 29, 7:28 PM
Unknown Object (File)
Wed, Jan 29, 2:35 AM
Unknown Object (File)
Sun, Jan 26, 6:00 AM
Unknown Object (File)
Fri, Jan 24, 1:43 PM
Unknown Object (File)
Fri, Jan 24, 1:43 PM
Unknown Object (File)
Fri, Jan 24, 1:42 PM
Unknown Object (File)
Tue, Jan 21, 11:10 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10905: Cannot triple-click to select task title in phabricator (due to icon in the title)
Commits
rPe8dca5a4f9be: Alternate fix for Firefox triple click selection
Summary

Fixes T10905. This reverts D15823, which didn't work well for tasks with very long titles (the title would break as a block element).

This is slightly more magic but works with long titles.

Test Plan

Did everything from D15823, but also with long titles. Triple-click, wrapping, and mobile/device worked in Safari, Firefox and Chrome.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38123.Apr 29 2016, 11:56 PM
epriestley retitled this revision from to Alternate fix for Firefox triple click selection.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10905: Cannot triple-click to select task title in phabricator (due to icon in the title).
Herald edited edge metadata. · View Herald TranscriptApr 29 2016, 11:56 PM
chad accepted this revision.Apr 29 2016, 11:58 PM
chad edited edge metadata.

shipitquick

This revision is now accepted and ready to land.Apr 29 2016, 11:58 PM
Closed by commit rPe8dca5a4f9be: Alternate fix for Firefox triple click selection (authored by epriestley, committed by epriestley). · Explain WhyApr 29 2016, 11:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
view/
phui/
9 lines
webroot/
rsrc/
css/
phui/
6 lines

Diff 38124

View Options

resources/celerity/map.php

Loading...
View Options

src/view/phui/PHUIHeaderView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-header-view.css

Loading...
Phabricator · Built by Phacility