Page MenuHomePhabricator

Document all the hypothetical URI features we plan to support soon
ClosedPublic

Authored by epriestley on Apr 28 2016, 8:35 PM.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley retitled this revision from to Document all the hypothetical URI features we plan to support soon.Apr 28 2016, 8:35 PM
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley updated this revision to Diff 38098.
chad edited edge metadata.Apr 28 2016, 8:40 PM
chad accepted this revision.
This revision is now accepted and ready to land.Apr 28 2016, 8:40 PM
scode added a subscriber: scode.Apr 28 2016, 8:41 PM
scode added inline comments.
src/docs/user/userguide/diffusion_uris.diviner
88

FWIW, a pitfall we ran into was that during the initial import, unless you too steps to avoid it, the initial import generates email. We ended up disabling autoclose and notify/push during the initial import to avoid this.

This may have been PEBKAC or a problem specific to us; I just thought I'd mention it in case it affects normal users and may be worth warning about here.

eadler added a subscriber: eadler.Apr 28 2016, 8:48 PM
eadler added inline comments.
src/docs/user/userguide/diffusion_uris.diviner
88

this is the documented reason for those knobs existing. T9554 is related.

I'm guessing you probably hit T9554; I'll either fix that or caution about this before removing the scary header from this document. I think it will automatically fix itself when the distinction between "hosted" and "imported" repositories partially dissolves Fairly Soon Now, but I'll make a note for myself to double check this.

epriestley edited edge metadata.Apr 28 2016, 8:59 PM
epriestley updated this revision to Diff 38099.
  • "specific specific", comma here and there.
This revision was automatically updated to reflect the committed changes.