Page MenuHomePhabricator
Differential D15807

Improve cache behaviors for font files and other nonstandard resource types
ClosedPublic
Actions

Authored by epriestley on Apr 27 2016, 1:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 18, 3:11 AM
Unknown Object (File)
Thu, Apr 4, 12:19 AM
Unknown Object (File)
Wed, Apr 3, 9:40 PM
Unknown Object (File)
Wed, Apr 3, 5:27 PM
Unknown Object (File)
Wed, Apr 3, 3:13 PM
Unknown Object (File)
Wed, Apr 3, 3:13 PM
Unknown Object (File)
Wed, Apr 3, 2:39 PM
Unknown Object (File)
Sun, Mar 31, 6:47 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10843: Don't write Celerity resources which aren't defined in the local map to cache
Commits
rPfbc4967154ba: Improve cache behaviors for font files and other nonstandard resource types
Summary

Ref T10843. There are actually two separate notions of cacheability here:

  • Is this cacheable by the browser (e.g., should we emit "Expires: long in the future")?
  • Is this cacheable locally (e.g., should we stick it in APC, or just read it off disk every time)?

These got a little mixed up by D15775, so we aren't currently emitting proper "Expires" headers on font files and a few other resource types.

Straighten this out so that we "Expires" these unusual resources correctly.

Test Plan

Verified that .woff files get a proper "Expires" header now, not just CSS/JS.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38080.Apr 27 2016, 1:46 PM
epriestley retitled this revision from to Improve cache behaviors for font files and other nonstandard resource types.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10843: Don't write Celerity resources which aren't defined in the local map to cache.
chad accepted this revision.Apr 27 2016, 1:56 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 27 2016, 1:56 PM
Closed by commit rPfbc4967154ba: Improve cache behaviors for font files and other nonstandard resource types (authored by epriestley, committed by epriestley). · Explain WhyApr 27 2016, 2:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
celerity/
controller/
8 lines

Diff 38081

View Options

src/applications/celerity/controller/CelerityResourceController.php

Loading...
Phabricator · Built by Phacility