Page MenuHomePhabricator

Improve cache behaviors for font files and other nonstandard resource types
ClosedPublic

Authored by epriestley on Apr 27 2016, 1:46 PM.
Tags
None
Referenced Files
F19303120: D15807.id.diff
Tue, Dec 23, 6:20 PM
F19255534: D15807.diff
Mon, Dec 22, 12:39 PM
F19055073: D15807.id38081.diff
Nov 28 2025, 3:45 PM
F18967782: D15807.id38080.diff
Nov 14 2025, 10:19 PM
F18933665: D15807.id.diff
Nov 10 2025, 11:59 AM
F18809912: D15807.id.diff
Oct 19 2025, 6:02 PM
F18808611: D15807.id38081.diff
Oct 19 2025, 7:29 AM
F18805033: D15807.diff
Oct 18 2025, 1:19 PM
Subscribers
None

Details

Summary

Ref T10843. There are actually two separate notions of cacheability here:

  • Is this cacheable by the browser (e.g., should we emit "Expires: long in the future")?
  • Is this cacheable locally (e.g., should we stick it in APC, or just read it off disk every time)?

These got a little mixed up by D15775, so we aren't currently emitting proper "Expires" headers on font files and a few other resource types.

Straighten this out so that we "Expires" these unusual resources correctly.

Test Plan

Verified that .woff files get a proper "Expires" header now, not just CSS/JS.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Improve cache behaviors for font files and other nonstandard resource types.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 27 2016, 1:56 PM
This revision was automatically updated to reflect the committed changes.