Page MenuHomePhabricator

When multiple web hosts are in service, don't require setup warnings to be dismissed on each one
ClosedPublic

Authored by epriestley on Apr 26 2016, 2:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 15, 11:48 PM
Unknown Object (File)
Thu, Apr 11, 8:31 AM
Unknown Object (File)
Mon, Apr 8, 10:38 AM
Unknown Object (File)
Wed, Apr 3, 5:35 AM
Unknown Object (File)
Tue, Apr 2, 7:31 AM
Unknown Object (File)
Sun, Mar 31, 2:26 PM
Unknown Object (File)
Sun, Mar 31, 2:26 PM
Unknown Object (File)
Sun, Mar 31, 12:10 PM
Subscribers
None

Details

Summary

Fixes T10876. Currently, we can end up with a setup warning banner sticking on each web device, since the state is stored in local cache.

Instead:

  • When we actually run the setup checks, save the current state in the database.
  • Before we show a cached banner, make sure the database still says the checks are a problem.

This could lead to some inconsistencies if setup checks legitimately pass on some hosts but not on others. For example, if you have git installed on one machine but not on another, we may raise a setup warning ("No Git Binary!") about it on one host only.

For now, assume users have their operational environments in some sort of reasonable shape and can install the same stuff everywhere. In the future, we could split the issues into "global" and "per-host" issues if we run into problems with this.

Test Plan

This is somewhat tricky to test locally since you really need multiple webservers to test it properly, but I:

  • Created some setup issues, saw banner.
  • Ignored/cleared them, saw banner go away.
  • Verified database cache writes were occurring properly.

Then I sort of faked it like this:

  • Created a setup issue.
  • Manually set the database cache value to [] ("no issues").
  • Reloaded page.
  • No more banner.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to When multiple web hosts are in service, don't require setup warnings to be dismissed on each one.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 26 2016, 4:00 PM
This revision was automatically updated to reflect the committed changes.