Page MenuHomePhabricator
Differential D15784

Improve consistency of file access policies, particularly for LFS
ClosedPublic
Actions

Authored by epriestley on Apr 22 2016, 11:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 27, 11:05 AM
Unknown Object (File)
Apr 21 2025, 9:42 AM
Unknown Object (File)
Apr 20 2025, 4:27 AM
Unknown Object (File)
Apr 19 2025, 12:36 PM
Unknown Object (File)
Apr 18 2025, 12:50 PM
Unknown Object (File)
Apr 17 2025, 12:59 PM
Unknown Object (File)
Apr 16 2025, 5:49 PM
Unknown Object (File)
Apr 16 2025, 10:42 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T7789: Support Git Large File Storage
Commits
rPab20f243b341: Improve consistency of file access policies, particularly for LFS
Summary

Ref T7789. Currently, we use different viewers if you have security.alternate-file-domain configured vs if you do not.

This is largely residual from the days of one-time-tokens, and can cause messy configuration-dependent bugs like the one in T7789#172057.

Instead, always use the omnipotent viewer. Knowledge of the secret key alone is sufficient to access a file.

Test Plan
  • Disabled security.alternate-file-domain.
  • Reproduced an issue similar to the one described on T7789.
  • Applied change.
  • Clean LFS interaction.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38025.Apr 22 2016, 11:45 AM
epriestley retitled this revision from to Improve consistency of file access policies, particularly for LFS.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T7789: Support Git Large File Storage.
epriestley mentioned this in T7789: Support Git Large File Storage.Apr 22 2016, 11:47 AM
chad accepted this revision.Apr 22 2016, 2:33 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 22 2016, 2:33 PM
Closed by commit rPab20f243b341: Improve consistency of file access policies, particularly for LFS (authored by epriestley, committed by epriestley). · Explain WhyApr 22 2016, 3:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
files/
controller/
22 lines

Diff 38031

View Options

src/applications/files/controller/PhabricatorFileDataController.php

Loading...
Phabricator · Built by Phacility