Page MenuHomePhabricator
Differential D15765

Fix an issue with PHID/handle management in push logs
ClosedPublic
Actions

Authored by epriestley on Apr 20 2016, 3:26 AM.
Tags
None
Referenced Files
F15384199: D15765.id.diff
Fri, Mar 14, 7:07 PM
F15380565: D15765.diff
Fri, Mar 14, 3:38 AM
F15377809: D15765.id37983.diff
Thu, Mar 13, 10:51 AM
Unknown Object (File)
Tue, Feb 25, 5:47 AM
Unknown Object (File)
Feb 22 2025, 12:09 AM
Unknown Object (File)
Feb 9 2025, 1:22 AM
Unknown Object (File)
Feb 9 2025, 1:22 AM
Unknown Object (File)
Feb 9 2025, 1:22 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10751: Make Phabricator Highly Available
Commits
rPb9cf9e6f0db9: Fix an issue with PHID/handle management in push logs
Summary

Ref T10751. This cleans this up so it's a little more modern, and fixes a possible bad access on the log detail page.

Test Plan

Viewed push log list, viewed push log detail.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37983.Apr 20 2016, 3:26 AM
epriestley retitled this revision from to Fix an issue with PHID/handle management in push logs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10751: Make Phabricator Highly Available.
chad accepted this revision.Apr 20 2016, 4:14 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 20 2016, 4:14 AM
Closed by commit rPb9cf9e6f0db9: Fix an issue with PHID/handle management in push logs (authored by epriestley, committed by epriestley). · Explain WhyApr 20 2016, 11:47 AM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T10751: Make Phabricator Highly Available.Apr 21 2016, 9:06 PM

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
3 lines
view/
24 lines
repository/
query/
14 lines

Diff 37986

View Options

src/applications/diffusion/controller/DiffusionPushEventViewController.php

Loading...
View Options

src/applications/diffusion/view/DiffusionPushLogListView.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositoryPushLogSearchEngine.php

Loading...
Phabricator · Built by Phacility