Page MenuHomePhabricator

Remove the warning about the Git 2GB pathname issue
ClosedPublic

Authored by epriestley on Apr 19 2016, 1:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 12, 9:25 PM
Unknown Object (File)
Thu, Apr 4, 6:01 AM
Unknown Object (File)
Mon, Apr 1, 3:14 AM
Unknown Object (File)
Mon, Apr 1, 3:14 AM
Unknown Object (File)
Fri, Mar 22, 7:11 AM
Unknown Object (File)
Feb 6 2024, 9:48 AM
Unknown Object (File)
Feb 1 2024, 2:39 AM
Unknown Object (File)
Jan 22 2024, 6:03 AM
Subscribers
None

Details

Summary

Ref T10832. In practice, git --version is not a useful test for this issue:

  • Vendors like Debian have backported the patch into custom versions like 0.0.0.1-debian-lots-of-patches.3232.
  • Vendors like Ubuntu distribute multiple different versions which report the same string from git --version, some of which are patched and some of which are not.

In other cases, we can perform an empirical test for the vulnerability. Here, we can not, because we can't write a 2GB path in a reasonable amount of time.

Since vendors (other than Apple) generally seem to be on top of this and any warning we try to raise based on git --version will frequently be incorrect, don't raise this warning.

I'll note this in the changelog instead.

Test Plan

Looked at setup issues, no more warning for vulnerable git version.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Remove the warning about the Git 2GB pathname issue.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 19 2016, 1:59 PM
This revision was automatically updated to reflect the committed changes.