Page MenuHomePhabricator

Allow public users to make intracluster API requests
ClosedPublic

Authored by epriestley on Apr 13 2016, 11:29 AM.

Details

Summary

Ref T10784. On secure, logged-out users currently can't browse repositories when cluster/service mode is enabled because they aren't permitted to make intracluster requests.

We don't allow totally public external requests (they're hard to rate limit and users might write bots that polled feed.query or whatever which we'd have no way to easily disable) but it's fine to allow intracluster public requests.

Test Plan

Browsed a clustered repository while logged out locally.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow public users to make intracluster API requests.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 13 2016, 1:57 PM
epriestley edited edge metadata.
  • Slightly cleaner diff that puts more logic in canEstablishAPISessions().
This revision was automatically updated to reflect the committed changes.