Differential D15685

Rough cut of repository cluster status panel
ClosedPublic
Actions

Authored by epriestley on Apr 11 2016, 6:40 PM.

Tags

None

Referenced Files

	F14843462: D15685.diff
	Sun, Feb 2, 7:00 AM

	Unknown Object (File)
	Tue, Jan 28, 1:14 AM

	Unknown Object (File)
	Sat, Jan 25, 9:23 PM

	Unknown Object (File)
	Fri, Jan 24, 1:00 PM

	Unknown Object (File)
	Fri, Jan 24, 1:00 PM

	Unknown Object (File)
	Fri, Jan 24, 1:00 PM

	Unknown Object (File)
	Fri, Jan 24, 1:00 PM

	Unknown Object (File)
	Fri, Jan 24, 3:57 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T4292: Implement repository replication

Commits

rP58eef68b7c60: Rough cut of repository cluster status panel

Summary

Ref T4292. This adds some very basic cluster/device data to the new management view. Nothing interesting yet.

Also deal with disabled bindings a little more cleanly.

Test Plan

Screen Shot 2016-04-11 at 11.37.51 AM.png (908×1 px, 118 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37794.Apr 11 2016, 6:40 PM

epriestley retitled this revision from to Rough cut of repository cluster status panel.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T4292: Implement repository replication.

chad added inline comments.Apr 11 2016, 6:54 PM

src/applications/diffusion/management/DiffusionRepositoryClusterManagementPanel.php
110	Can this just say "Documentation". I think the header text should make it clear.
src/docs/user/cluster/cluster.diviner
57	does this need to match the actual tite? If so should be "Cluster: Repository"

Fix document title.
I think the long link names are better for blind users, since screen readers have features to read all the links on a page without context. Like "Read More", or "Click Here" links with vague names like "Documentation" may not be clear. But whatever; shorten 'em.

chad accepted this revision.Apr 11 2016, 7:02 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Apr 11 2016, 7:02 PM

Closed by commit rP58eef68b7c60: Rough cut of repository cluster status panel (authored by epriestley, committed by epriestley). · Explain WhyApr 12 2016, 12:38 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T10751: Make Phabricator Highly Available.Apr 13 2016, 3:33 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

controller/

PhabricatorConfigClusterDatabasesController.php

2 lines

diffusion/

management/

DiffusionRepositoryClusterManagementPanel.php

111 lines

repository/

daemon/

PhabricatorRepositoryPullLocalDaemon.php

20 lines

docs/

user/

cluster/

cluster.diviner

17 lines

cluster_repositories.diviner

86 lines

Diff 37802

src/applications/config/controller/PhabricatorConfigClusterDatabasesController.php

Loading...

src/applications/diffusion/management/DiffusionRepositoryClusterManagementPanel.php

Loading...

src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php

Loading...

src/docs/user/cluster/cluster.diviner

Loading...

src/docs/user/cluster/cluster_repositories.diviner

Loading...