Page MenuHomePhabricator

Fix an issue with date parsing when viewer timezone differs from server timezone
ClosedPublic

Authored by epriestley on Apr 11 2016, 2:37 PM.

Details

Summary

The way DateTime works with epochs is weird, I goofed this by having my server/viewer timezone the same and not noticing.

Also fix an issue where you do ?epoch=... and then manually fiddle with the control: the control should win.

Test Plan
  • Set viewer and server timezone to different vlaues.
  • Created a countdown using ?epoch=....
  • Created a countdown using ?epoch=... and fiddling with date controls.
  • Created and edited a countdown using date/time control.
  • Poked around Calendar to make sure I didn't ruin anything this time (browsed, created event, edited event).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix an issue with date parsing when viewer timezone differs from server timezone.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, lpriestley.
chad edited edge metadata.

Your viewer is gmt?

This revision is now accepted and ready to land.Apr 11 2016, 2:47 PM
This revision was automatically updated to reflect the committed changes.

For testing this, my viewer was EST and my server was PDT (I think?).

For the original bug on C144, the server (secure.phabricator.com) is UTC/GMT, and my viewer is PDT.