Page MenuHomePhabricator

Fix an issue with passing HTTP headers through in proxied cluster requests
ClosedPublic

Authored by epriestley on Apr 8 2016, 5:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 20, 2:19 AM
Unknown Object (File)
Tue, Mar 5, 6:06 PM
Unknown Object (File)
Tue, Mar 5, 6:05 PM
Unknown Object (File)
Tue, Feb 27, 6:09 PM
Unknown Object (File)
Tue, Feb 27, 5:58 PM
Unknown Object (File)
Feb 9 2024, 10:12 AM
Unknown Object (File)
Feb 3 2024, 9:37 AM
Unknown Object (File)
Jan 25 2024, 7:25 PM
Subscribers
None

Details

Summary

I think this fixes the Mercurial + HTTP cluster issue. PHP adds HTTP_ but we were not stripping it, so we would convert an X-Whatever-Zebra header into an Http-X-Whatever-Zebra header.

I don't think this behavior has changed? So maybe it just never worked? Git is more popular than Mercurial and SSH is easier to configure than HTTP, so it's plausible. I'll keep a careful eye on this when it deploys.

Test Plan
  • Set up local service-based Mercurial repository.
  • Tried to clone, got similar error to cluster.
  • Applied patch, clean clone.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix an issue with passing HTTP headers through in proxied cluster requests.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 8 2016, 6:03 PM
This revision was automatically updated to reflect the committed changes.