Page MenuHomePhabricator
Differential D15653

Account for raw limits properly in CalendarEventQuery
ClosedPublic
Actions

Authored by epriestley on Apr 7 2016, 12:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 7:44 AM
Unknown Object (File)
Fri, Dec 13, 10:54 AM
Unknown Object (File)
Wed, Dec 11, 10:09 PM
Unknown Object (File)
Wed, Dec 11, 9:29 AM
Unknown Object (File)
Tue, Dec 10, 8:11 AM
Unknown Object (File)
Tue, Dec 10, 5:22 AM
Unknown Object (File)
Sun, Dec 8, 3:04 AM
Unknown Object (File)
Thu, Dec 5, 7:09 AM
View All Files
Subscribers
None

Details

Reviewers
lpriestley
chad
Maniphest Tasks
T8613: `rawResultLimit` getting set to 0 when querying for events for user availability
Commits
rP27104b57c827: Account for raw limits properly in CalendarEventQuery
Summary

Fixes T8613. This was pretty straightforward, I just never dug into it originally.

rawResultLimit = 0 just means "no limit", so the fix is to only apply a limit if it is set to some nonzero value.

Also modernize a few pieces of code.

Test Plan

I'm actually not sure this can actually be hit normally? I faked setGenerateGhosts(true) into an unrelated query, hit the fatal, then fixed it.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37720.Apr 7 2016, 12:23 PM
epriestley retitled this revision from to Account for raw limits properly in CalendarEventQuery.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, lpriestley.
epriestley added a task: T8613: `rawResultLimit` getting set to 0 when querying for events for user availability.
epriestley updated this revision to Diff 37721.Apr 7 2016, 12:26 PM
  • Slightly cleaner fix.
epriestley added a comment.Apr 7 2016, 12:33 PM

We should probably add a check here that requires either a limit or an end date, because otherwise you may generate infinite events. Let me add that safety test.

epriestley updated this revision to Diff 37722.Apr 7 2016, 12:35 PM
  • If an event generates ghosts, but has no limit and no end date, fatal so we don't generate inifnite events.
chad accepted this revision.Apr 7 2016, 1:58 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 7 2016, 1:58 PM
Closed by commit rP27104b57c827: Account for raw limits properly in CalendarEventQuery (authored by epriestley, committed by epriestley). · Explain WhyApr 7 2016, 3:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
query/
76 lines
people/
query/
4 lines

Diff 37724

View Options

src/applications/calendar/query/PhabricatorCalendarEventQuery.php

Loading...
View Options

src/applications/people/query/PhabricatorPeopleQuery.php

Loading...
Phabricator · Built by Phacility