Page MenuHomePhabricator

Improve Amazon SES code error handling behavior
ClosedPublic

Authored by epriestley on Apr 6 2016, 12:02 AM.
Tags
None
Referenced Files
F13142240: D15632.diff
Fri, May 3, 5:53 AM
Unknown Object (File)
Wed, May 1, 1:17 PM
Unknown Object (File)
Thu, Apr 25, 12:58 AM
Unknown Object (File)
Fri, Apr 19, 4:23 PM
Unknown Object (File)
Mon, Apr 15, 5:30 AM
Unknown Object (File)
Sun, Apr 14, 9:11 PM
Unknown Object (File)
Thu, Apr 11, 8:43 AM
Unknown Object (File)
Mon, Apr 8, 11:18 AM
Subscribers
None

Details

Summary

Fixes T10728. Fixes T10476. SES uses third-party code with unique, creative ideas about error handling.

  • Make the error handling behavior more correct, so it doesn't try to use undefined variables.
  • Simplify the error handling behavior (throw exceptions sooner, remove redundant code).
  • Explicitly test for -smtp misconfigurations. These can arise if you read the wrong column out of the table in the AWS docs, as in T10728.
  • Explicitly test for SimpleXML, to catch T10476 before it does damage.
Test Plan
  • Configured SES to use a bogus SMTP endpoint.
  • Faked past the SMTP check, hit sane error on the connection.
  • Undid faking, hit immediate hard stop on the STMP check.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable