Page MenuHomePhabricator

Improve Amazon SES code error handling behavior
ClosedPublic

Authored by epriestley on Apr 6 2016, 12:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 14, 11:51 PM
Unknown Object (File)
Tue, Dec 10, 3:02 PM
Unknown Object (File)
Fri, Dec 6, 10:24 PM
Unknown Object (File)
Wed, Dec 4, 3:47 PM
Unknown Object (File)
Thu, Nov 28, 1:18 PM
Unknown Object (File)
Thu, Nov 28, 12:57 PM
Unknown Object (File)
Thu, Nov 28, 11:34 AM
Unknown Object (File)
Sun, Nov 24, 12:33 AM
Subscribers
None

Details

Summary

Fixes T10728. Fixes T10476. SES uses third-party code with unique, creative ideas about error handling.

  • Make the error handling behavior more correct, so it doesn't try to use undefined variables.
  • Simplify the error handling behavior (throw exceptions sooner, remove redundant code).
  • Explicitly test for -smtp misconfigurations. These can arise if you read the wrong column out of the table in the AWS docs, as in T10728.
  • Explicitly test for SimpleXML, to catch T10476 before it does damage.
Test Plan
  • Configured SES to use a bogus SMTP endpoint.
  • Faked past the SMTP check, hit sane error on the connection.
  • Undid faking, hit immediate hard stop on the STMP check.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable