Page MenuHomePhabricator

Improve Amazon SES code error handling behavior
ClosedPublic

Authored by epriestley on Apr 6 2016, 12:02 AM.
Tags
None
Referenced Files
F18588143: D15632.id37671.diff
Thu, Sep 11, 11:23 PM
F18586025: D15632.id37671.diff
Thu, Sep 11, 5:12 PM
F18583420: D15632.id37670.diff
Thu, Sep 11, 10:20 AM
F18356491: D15632.diff
Wed, Aug 27, 5:47 AM
F17868754: D15632.diff
Jul 28 2025, 9:26 AM
F17657298: D15632.diff
Jul 12 2025, 12:13 PM
Unknown Object (File)
Jun 21 2025, 4:25 AM
Unknown Object (File)
Jun 18 2025, 2:46 PM
Subscribers
None

Details

Summary

Fixes T10728. Fixes T10476. SES uses third-party code with unique, creative ideas about error handling.

  • Make the error handling behavior more correct, so it doesn't try to use undefined variables.
  • Simplify the error handling behavior (throw exceptions sooner, remove redundant code).
  • Explicitly test for -smtp misconfigurations. These can arise if you read the wrong column out of the table in the AWS docs, as in T10728.
  • Explicitly test for SimpleXML, to catch T10476 before it does damage.
Test Plan
  • Configured SES to use a bogus SMTP endpoint.
  • Faked past the SMTP check, hit sane error on the connection.
  • Undid faking, hit immediate hard stop on the STMP check.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable